feat: add security header #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2341 +/- ##
===========================================
- Coverage 68.17% 49.10% -19.08%
===========================================
Files 127 41 -86
Lines 3375 3179 -196
Branches 830 0 -830
===========================================
- Hits 2301 1561 -740
- Misses 1074 1419 +345
- Partials 0 199 +199
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
nic-chen
approved these changes
Mar 9, 2022
|
@starsz Please take a look, thanks. |
starsz
reviewed
Mar 11, 2022
api/conf/conf.yaml
Outdated
| @@ -60,6 +60,14 @@ conf: | |||
| # such as absolute path on Windows: winfile:///C:\access.log | |||
| # log example: 2020-12-09T16:38:09.039+0800 INFO filter/logging.go:46 /apisix/admin/routes/r1 {"status": 401, "host": "127.0.0.1:9000", "query": "asdfsafd=adf&a=a", "requestId": "3d50ecb8-758c-46d1-af5b-cd9d1c820156", "latency": 0, "remoteIP": "127.0.0.1", "method": "PUT", "errs": []} | |||
| max_cpu: 0 # supports tweaking with the number of OS threads are going to be used for parallelism. Default value: 0 [will use max number of available cpu cores considering hyperthreading (if any)]. If the value is negative, is will not touch the existing parallelism profile. | |||
| # security: | |||
| # access_control_allow_origin: "http:httpbin.org" | |||
There was a problem hiding this comment.
Suggested change
| # access_control_allow_origin: "http:httpbin.org" | |
| # access_control_allow_origin: "http://httpbin.org" |
api/conf/conf.yaml
Outdated
| @@ -60,6 +60,14 @@ conf: | |||
| # such as absolute path on Windows: winfile:///C:\access.log | |||
| # log example: 2020-12-09T16:38:09.039+0800 INFO filter/logging.go:46 /apisix/admin/routes/r1 {"status": 401, "host": "127.0.0.1:9000", "query": "asdfsafd=adf&a=a", "requestId": "3d50ecb8-758c-46d1-af5b-cd9d1c820156", "latency": 0, "remoteIP": "127.0.0.1", "method": "PUT", "errs": []} | |||
| max_cpu: 0 # supports tweaking with the number of OS threads are going to be used for parallelism. Default value: 0 [will use max number of available cpu cores considering hyperthreading (if any)]. If the value is negative, is will not touch the existing parallelism profile. | |||
| # security: | |||
| # access_control_allow_origin: "http:httpbin.org" | |||
| # access_control_allow_credentials: true # support user custom cors configration | |||
There was a problem hiding this comment.
Suggested change
| # access_control_allow_credentials: true # support user custom cors configration | |
| # access_control_allow_credentials: true # support using custom cors configration |
api/internal/filter/cors.go
Outdated
| @@ -16,14 +16,36 @@ | |||
| */ | |||
| package filter | |||
|
|
|||
| import "github.com/gin-gonic/gin" | |||
| import ( | |||
| "github.com/apisix/manager-api/internal/conf" | |||
| SecurityConf = Security{ | ||
| XFrameOptions: "deny", | ||
| ContentSecurityPolicy: "default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline'", | ||
| } |
There was a problem hiding this comment.
So we don't have the default value of AllowCredentials AllowOrigin AllowMethods AllowHeaders
There was a problem hiding this comment.
We don't need default value for AllowCredentials、AlloOrigin、AllowMethods、AllowHeaders. These configuration are left to the user to customize.
starsz
approved these changes
Mar 14, 2022
bzp2010
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/ #2340
Checklist: